Conversation
Luthaf
left a comment
There was a problem hiding this comment.
Many thanks for this PR, this is amazing!
I have a couple of high level questions/suggestions about code organization before digging deeper.
Is the plan to also have the sycl backend available through Python / TorchScript / Jax?
|
I have not tried Python / TorchScript / Jax. I could make it work for the examples. I have not ported the backward method, which would be instrumental for training workloads. I am working on that. |
|
We have 20% of speed up when we use the SYCL version of sphericart in symmetrix with LAMMPS (42k atmos, 100 steps, double precision)
Let me know if there is anything else to change. |
|
@alvarovm Thank you very much for the contribution! We're looking through the code, hopefully we'll be able to make some finishing touches and merge it relatively soon |
|
I'm going to revert all the DTYPE -> T changes for the moment to make things easier to review. We'll open a different PR for them later |
|
cscs-ci run |
|
cscs-ci run |
|
I have not tested the backward function, and the pytorch integration, I will complete this during April. Inference with C++ and Kokkos is OK, we are using this for production. |
I added support to SYCL devices. I include example_sycl and benchmark_sycl. I tested this on an Intel laptop with CPU and GPU (Xe Iris) and Intel GPU Ponte Vecchio (~Max 1550), I expect this could also run in Nvidia, AMD and Intel Ultra, but I have not tested.
I tested this with symmetrix and ran MD with MACE models. OK.